Closed trieloff closed 4 years ago
Haven't tested myself. Happy to take your word for it @trieloff. Thanks for the PR, LGTM
Published to npm, version5.0.0
. Closes #45
Awesome. Thanks for the speedy merge and release, Jack.
@jacktuck it looks like the version published to NPM does not have the fix applied to the dist
files.
🤦♂ I forgot this project was TS. Will do a patch later.
Thanks, I was beginning to question my sanity when the tests in my project wouldn't pass, while the same test in your project did. Then I took a look at the dist
.
@trieloff Just released Release 5.0.1 with a new build
:tada: This PR is included in version 1.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
We have had issues with a failing build in https://github.com/adobe/helix-embed/pull/84 caused by the inability to get proper OEmbeds from Youtube. Youtube uses
&
entity references in the OEmbedhref
, whichunfurl
is not parsing correctly – details laid out in #45This PR fixes it by decoding the
href
usinghe
before trying to retrieve and resolve the remote metadata.