Decode entity references in OEmbed hrefs

[trieloff]

We have had issues with a failing build in https://github.com/adobe/helix-embed/pull/84 caused by the inability to get proper OEmbeds from Youtube. Youtube uses & entity references in the OEmbed href, which unfurl is not parsing correctly – details laid out in #45

This PR fixes it by decoding the href using he before trying to retrieve and resolve the remote metadata.

[coveralls]

Coverage remained the same at 98.452% when pulling f3ca50cc62e04f42c9f5b5257ae3300b6ce82c5a on trieloff:decode-youtube-hrefs into 952c4031a9ae36a907349215a1b7fd82c91ab451 on jacktuck:master.

[coveralls]

Coverage remained the same at 98.452% when pulling f3ca50cc62e04f42c9f5b5257ae3300b6ce82c5a on trieloff:decode-youtube-hrefs into 952c4031a9ae36a907349215a1b7fd82c91ab451 on jacktuck:master.

[coveralls]

Coverage remained the same at 98.452% when pulling f3ca50cc62e04f42c9f5b5257ae3300b6ce82c5a on trieloff:decode-youtube-hrefs into 952c4031a9ae36a907349215a1b7fd82c91ab451 on jacktuck:master.

[jacktuck]

Haven't tested myself. Happy to take your word for it @trieloff. Thanks for the PR, LGTM

[jacktuck]

Published to npm, version5.0.0. Closes #45

[trieloff]

Awesome. Thanks for the speedy merge and release, Jack.

[trieloff]

@jacktuck it looks like the version published to NPM does not have the fix applied to the dist files.

[jacktuck]

🤦‍♂ I forgot this project was TS. Will do a patch later.

[trieloff]

Thanks, I was beginning to question my sanity when the tests in my project wouldn't pass, while the same test in your project did. Then I took a look at the dist.

[jacktuck]

@trieloff Just released Release 5.0.1 with a new build

[github-actions[bot]]

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: