jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
473 stars 51 forks source link

OEmbed for SoundCloud isn't resolved #48

Closed trieloff closed 4 years ago

trieloff commented 4 years ago

Trying with https://soundcloud.com/cheryl-lin-fielding/chanson-pour-jeanne?in=cheryl-lin-fielding/sets/website I'm getting following results:

{ title:
   'Chabrier: Chanson pour Jeanne - Efrain Solis, Baritone & Cheryl Lin Fielding, Piano by Cheryl Lin Fielding | Free Listening on SoundCloud',
  keywords:
   [ 'record',
     'sounds',
     'share',
     'sound',
     'audio',
     'tracks',
     'music',
     'soundcloud' ],
  open_graph:
   { site_name: 'SoundCloud',
     type: 'music.song',
     url:
      'https://soundcloud.com/cheryl-lin-fielding/chanson-pour-jeanne',
     title:
      'Chabrier: Chanson pour Jeanne - Efrain Solis, Baritone & Cheryl Lin Fielding, Piano',
     images: [ [Object] ],
     description:
      'Efrain Solis, Baritone\nCheryl Lin Fielding, Piano\nLive performance' },
  twitter_card:
   { site: 'SoundCloud',
     apps: { iphone: [Object], ipad: [Object], googleplay: [Object] },
     title:
      'Chabrier: Chanson pour Jeanne - Efrain Solis, Baritone & Cheryl Lin Fielding, Piano',
     description:
      'Efrain Solis, Baritone\nCheryl Lin Fielding, Piano\nLive performance',
     players: [ [Object] ],
     images: [ [Object] ],
     card: 'player' },
  description:
   'Stream Chabrier: Chanson pour Jeanne - Efrain Solis, Baritone & Cheryl Lin Fielding, Piano by Cheryl Lin Fielding from desktop or your mobile device',
  favicon:
   'https://a-v2.sndcdn.com/assets/images/sc-icons/favicon-2cadd14bdb.ico' }

oembed is missing, despite being provided by SoundCloud.

I have identified the root cause and will provide a PR.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: