fix(oembed): relax regex for detecting XML responses

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:

MIT License

475 stars 51 forks source link

fix(oembed): relax regex for detecting XML responses #49

Closed trieloff closed 4 years ago

trieloff commented 4 years ago

both text/xml and application/xml are valid content types for OEmbed-XML responses

fix #48

/cc @royfielding

coveralls commented 4 years ago

Coverage remained the same at 98.452% when pulling fb17df164d9fe38ed688367a1860b66439839db3 on trieloff:soundcloud-oembed into a08dc9ac016910dda1c2c330aac7f1182c016bf6 on jacktuck:master.

coveralls commented 4 years ago

Coverage remained the same at 98.452% when pulling fb17df164d9fe38ed688367a1860b66439839db3 on trieloff:soundcloud-oembed into a08dc9ac016910dda1c2c330aac7f1182c016bf6 on jacktuck:master.

jacktuck commented 4 years ago

Thanks for this. Will merge and release later :)

trieloff commented 4 years ago

Hi @jacktuck I hope you had a good weekend. Let me know if there is anything else that needs to be done with this PR.

jacktuck commented 4 years ago

Should be all good. Have done a release. I really need to add some CI to this project 😆

trieloff commented 4 years ago

Let me know if you'd like a PR for a CircleCI + Semantic Release set-up.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: