search

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
475 stars 51 forks source link

Favicon #63

Closed wereHamster closed 3 years ago

wereHamster commented 4 years ago

It would be nice if the returned metadata included links to the favicon. Do you think such a feature is in scope of this package?

jacktuck commented 4 years ago

We should already be returning the favicon - so maybe the code for doing so needs tweaking.

https://github.com/jacktuck/unfurl/blob/76cab79ec1fbc02e9e3e2e928d224c4c52b8a26b/src/index.ts#L195

Do you have an example where the favicon is not being picked up?

wereHamster commented 4 years ago

I was not looking at the source code, I was looking at the Metadata type that is described in the readme, which does not mention the favicon. The favicon is indeed being extracted correctly in the few tests I did.

Maybe the readme can link directly to the TypeScript Metadata type in the source code instead of repeating it?

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 5.2.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: