Closed trieloff closed 3 years ago
:tada: This issue has been resolved in version 5.2.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
If it turns out title is often in the head but other meta is in the body we could in the future just remove this optimisation all together or default to not having it and add a option flag for it.
Youtube changed its HTML a month ago and since then our tests (https://github.com/adobe/helix-embed/pull/345) have been failing when verifying the output for Youtube.
The underlying issue is a combination of making the reasonable assumption that all metadata is in the
head
herehttps://github.com/jacktuck/unfurl/blob/db57429b369bae7e22f6983a7e19832c54101491/src/index.ts#L270-L273
and Youtube being above convention, standards, and reason:
(HTML reformatted and all
script
andstyle
tags removed)As you can see, most of the interesting metadata (even
title
) is outside thehead
.I will submit a PR to address that.