Fix Youtube OEmbed - Githubissues

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:

MIT License

474 stars 51 forks source link

Closed trieloff closed 3 years ago

trieloff commented 3 years ago

with youtube repeatedly breaking things, it is probably best to have an online test that runs against the real site, warts and all
youtube's oembed endpoint is only reachable using HTTPS, but the links on the site still point to the HTTP URL. This change tries to use HTTPS if the specified HTTP endpoint is not reachable

fixes #69

trieloff commented 3 years ago

Done & somewhat done. I'm just skiping the online test, as I expect YT to give us trouble again, and want to have a head start in testing.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 5.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: