search

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
474 stars 51 forks source link

Handle atomic tags in meta tags #72

Closed martip closed 3 years ago

martip commented 3 years ago

Hi Jack, thank you for sharing your wonderful code.

I noticed that some sites have empty (i.e. atomic) meta tags, such as <meta name="description"/> and <meta name="keywords"/>. We simply need to check if attrib.content exists before using it.

I fixed two lines of code (253 and 255).

Ciao, Paolo

jacktuck commented 3 years ago

Hi, I've tested your branch and confirmed the fix works. Thanks for taking the time to make this PR 🎉

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 5.2.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: