search

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
474 stars 51 forks source link

Incorrect metadata types #73

Closed henrykuzmick closed 3 years ago

henrykuzmick commented 3 years ago

Hey 👋 Thanks for the great lib! The Metadata type defines twitter_card and open_graph as arrays, but the received results are objects.

jacktuck commented 3 years ago

Hey Henry!

I've just had a look and you're right! 🤦 . Sorry, not quite sure how this went unnoticed (by me). Anyway, would you like to submit a PR for the fix? If not I'll take a look in the morning.

henrykuzmick commented 3 years ago

Sure, I'll try to ping you with a PR sometime tomorrow 👌