search

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
474 stars 51 forks source link

feat: add check to throw if http status is not 200 #78

Closed jacktuck closed 3 years ago

jacktuck commented 3 years ago

thanks @davidhq

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 5.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jacktuck commented 3 years ago

Annoyingly semantic release hasn't done a major release there but i think it should have done :(

davidhq commented 3 years ago

Nice, I see if (res.status !== 200) {, I thought this is better too but you said throw when 4xx or 5xx ... anyhow: great.

jacktuck commented 3 years ago

Yep that's my bad, hadn't thought about it in any depth before looking at your branch.