search

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
474 stars 51 forks source link

Add support article type in OGP specification #80

Closed fuji44 closed 3 years ago

fuji44 commented 3 years ago

Hi all.

I'm looking to support the article type as written in the OGP specification. The specification has the following description.

These are globally defined objects that just don't fit into a vertical but yet are broadly used and agreed upon.

I interpreted this as "not specified as an OGP, but widely used". I thought that some people might not like to support it with unfurl, depending on their interpretation of this statement.

Do you guys have any doubts about being able to handle article types in unfurl? If there is no doubt, I'd like to start working on it.

jacktuck commented 3 years ago

Hey @fuji44. I don't see any problem with us supporting this 👍

fuji44 commented 3 years ago

Thanks for the answer. I would like to work on this in my spare time.