eyetoy: frame size off by some bytes

jackun / USBqemu-wheel

PCSX2 usb plugin for wheels and increasingly more stuff

The Unlicense

121 stars 21 forks source link

eyetoy: frame size off by some bytes #55

Open jackun opened 4 years ago

jackun commented 4 years ago

https://github.com/jackun/USBqemu-wheel/blob/0ec87bcba7cc0fb555c60e8fca89b86fe42034c5/src/usb-eyetoy/usb-eyetoy-webcam.cpp#L455

Off by sizeof(header1) + sizeof(header2)?

Florin9doi commented 3 years ago

The total size (header1+2+mpeg_frame_data) is never calculated or used and mpeg_frame_offset is used to iterate in mpeg_frame_data, not in header1+2+mpeg_frame_data. I can't find any issue. Maybe to verify that data_pk isn't larger than mpeg_frame_size at first step, but is unlikely.