search

jackwilsdon / seedvault-extractor

MIT License
31 stars 7 forks source link

Skip @end@ meta package #7

Closed nettnikl closed 1 year ago

jackwilsdon commented 1 year ago

Do we know when these @end@ entries are generated? I can't see a @end@ key in my local backups and can't find any mention of it in the Seedvault codebase)

nettnikl commented 1 year ago

Interesting - i have no clue... Just saw it in a warning and in the metadata json

...
  "com.android.wallpaperbackup": {
        "time": 1684109833247,
        "backupType": "FULL",
        "system": true
    },
    "@end@": {
        "time": 1684118346539,
        "backupType": "KV",
        "system": true
    },
...
nettnikl commented 1 year ago

If anywhere, it should be here - but i also cannot find it. https://github.com/seedvault-app/seedvault/blob/android13/app/src/main/java/com/stevesoltys/seedvault/metadata/MetadataWriter.kt

jackwilsdon commented 1 year ago

Hmm interesting. We support extracting KV backups as of e2875f747801b520a3ef7edb2979b8ffb7a0c9a6 - does @end@ extract successfully for you or are you missing the file for that entry?

nettnikl commented 1 year ago

error: failed to extract "@end@": failed to open "/home/user/seedvault_backup_parser-master/1677281112300/WkbEap08kh7AMAeENbupNYR-RO3nVgt3tRDBgwjEor1": open /home/user/seedvault_backup_parser-master/1677281112300/WkbEap08kh7AMAeENbupNYR-RO3nVgt3tRDBgwjEor1: no such file or directory

nettnikl commented 1 year ago

It doesn't extract, and seems to only be there to specify how long the backup took, timing-wise.

jackwilsdon commented 1 year ago

Fair enough, thank you for investigating!