jackxiao / jslibs

Automatically exported from code.google.com/p/jslibs
0 stars 0 forks source link

Patch fixing compilation with gcc 4.3 #38

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Compiling on a newer version of Ubuntu, with gcc 4.3+, results in
errors.  You need to manually #include <cstring> in order to get memcpy()
and similar functions.  This occurs in jslang/bstring.cpp and
jssqlite/result.cpp

"In GCC 4.3 the C++ header dependencies have been cleaned up. ... The
downside is that programmers cannot rely on indirect inclusion of headers
they may need anymore. Instead, everything that is needed has to be
directly referenced with an #include."
[per http://www.cyrius.com/journal/2007/05/10#gcc-4.3-include]

I don't think this will adversely affect windows compilation, but I have
*not* tested it in MSVC.

In addition, you need to comment out #include <windows.h> in
jslang/stdafx.h to get it to compile -- you might not want to do this for
windows compilation; instead using some #ifdef construct.  Then again, it
seems to compile fine without it, so I don't know if it is actually needed.

Glenn Griffin / glenn@griffin3.com

Original issue reported on code.google.com by Griffin3...@gmail.com on 20 May 2008 at 8:09

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for reporting these issues. jslang module is quite new and haven't been 
tested
under Linux.

Original comment by sou...@gmail.com on 20 May 2008 at 8:49

GoogleCodeExporter commented 9 years ago

Original comment by sou...@gmail.com on 20 May 2008 at 8:50