jackyzha0 / quartz

🌱 a fast, batteries-included static-site generator that transforms Markdown content into fully functional websites
https://quartz.jzhao.xyz
MIT License
5.93k stars 2.37k forks source link

Popover Weird Interactions #1217

Open SheathedBlade opened 2 weeks ago

SheathedBlade commented 2 weeks ago

There's a few interactions with popovers that I'd like to list:

  1. Hovering over a link in the backlinks section generates a popover modal, but contained within the backlinks section, as shown in the image below: image

  2. Popovers do not cover certain elements of the page, see below for images. The callout icon is still shown, even though the popover is covering the callout section. Screenshot 2024-05-22 194333

The below image shows the popover not covering the footer: Screenshot 2024-05-22 194351

Point 2 could be a case of z-index getting confused(?) Point 1 I'm not entirely sure how to fix this, and also I think it could be useful to have a way to disable popovers for certain sections of the page (like disabling them for backlinks, or disabling them for just Explore, etc.)

kumas-k commented 2 weeks ago

Problems have occurred since #906 was applied.

jackyzha0 commented 2 weeks ago

can you see if https://github.com/jackyzha0/quartz/commit/541b470cfc85c342ba8b7548d58d668b49d8dd85 fixes it?

SheathedBlade commented 2 weeks ago

Looks like the above commit fixed it! I'll close this ticket.

SheathedBlade commented 2 weeks ago

Looks like point 2 still is a problem (for me). I was able to just bump the callout icon back with z-index, but I'm not sure how to bump the footer back. This might just be a "me" issue though, seems like a transparency issue with the modal, or the background of the modal is totally transparent.

jackyzha0 commented 2 weeks ago

Can you provide a markdown reproduction? Seems to work on https://quartz.jzhao.xyz/features/callouts

image
SheathedBlade commented 2 weeks ago

image

Seems to be an issue the sidebar popovers, since the main middle section popovers work fine. (like popovers from recent notes on the left sidebar)