jackyzha0 / quartz

๐ŸŒฑ a fast, batteries-included static-site generator that transforms Markdown content into fully functional websites
https://quartz.jzhao.xyz
MIT License
6.82k stars 2.47k forks source link

i18n: Improving Spanish & adding Catalan and British English #1240

Closed IL01DI closed 3 months ago

IL01DI commented 3 months ago

Hello! ๐Ÿ‘‹

I would like to make changes to the Spanish translation, replacing the infinitive form to conjugated present (of indicative) form, since it is more natural. Furthermore, some past tense verbs have also been replaced by their usage in Spain (not in America).

As for British English, I don't see any difference, but I would recommend adding it. Also, I provided a Catalan translation.

Thanks in advance, L01D

tremulotmaths commented 3 months ago

Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes:

๐Ÿ‘‰ Code Suggestion for #1240

https://github.com/jackyzha0/quartz/pull/1240

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest >[Code Suggest](https://gitkraken.dev/redirect/aHR0cHM6Ly93d3cuZ2l0a3Jha2VuLmNvbS9zb2x1dGlvbnMvY29kZS1zdWdnZXN0P3NvdXJjZT1naXRodWIuY29tJm1lZGl1bT1wcl9jb21tZW50?source=PRSuggest&event=redirectToCodeSuggestPage&provider=github) liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project โ€” not just on the lines of code changed in the PR. _Join your team on [GitKraken](https://gitkraken.dev/redirect/aHR0cHM6Ly93d3cuZ2l0a3Jha2VuLmNvbT9zb3VyY2U9Z2l0aHViLmNvbSZtZWRpdW09cHJfY29tbWVudA==?source=PRSuggest&event=redirectToIndexPage&provider=github) to speed up PR review._
Simber1 commented 3 months ago

+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB before my IDE yelled at me telling me it wasn't valid.

IL01DI commented 3 months ago

Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes:

๐Ÿ‘‰ Code Suggestion for #1240

1240

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

@tremulotmaths, why you suggested this kind of code in my PR? It doesn't involve on the topic at all.

IL01DI commented 3 months ago

+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB before my IDE yelled at me telling me it wasn't valid.

What do you mean specifically when you โ€œchanged it to en_GBโ€? I haven't tried yet, but the fact that isn't valid made me think that it might be the lack of support towards one language with multiple regions. Although qwartz theoretically supports it, I can't see any language with more regions added.

UPDATE: I tested it, and it works for me without any error.

Simber1 commented 3 months ago

+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB before my IDE yelled at me telling me it wasn't valid.

What do you mean specifically when you โ€œchanged it to en_GBโ€? I haven't tried yet, but the fact that isn't valid made me think that it might be the lack of support towards one language with multiple regions. Although qwartz theoretically supports it, I can't see any language with more regions added.

The other day (not using this branch) when I set up quartz I set the locale to en-GB and got a type error as the locale field is the type ValidLocale which only accepts locales in the TRANSLATIONS var in i18n/index.ts. Since you have added it to there it will be fine from a type hinting prospective.