Closed IL01DI closed 3 months ago
Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes:
๐ Code Suggestion for #1240
You can also review and apply these suggestions locally on your machine.
+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB
before my IDE yelled at me telling me it wasn't valid.
Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes:
๐ Code Suggestion for #1240
1240
You can also review and apply these suggestions locally on your machine.
Learn more about GitKraken Code Suggest
@tremulotmaths, why you suggested this kind of code in my PR? It doesn't involve on the topic at all.
+1 on the British English, when setting quartz up the other day I instinctively changed it to
en-GB
before my IDE yelled at me telling me it wasn't valid.
What do you mean specifically when you โchanged it to en_GB
โ? I haven't tried yet, but the fact that isn't valid made me think that it might be the lack of support towards one language with multiple regions. Although qwartz theoretically supports it, I can't see any language with more regions added.
UPDATE: I tested it, and it works for me without any error.
+1 on the British English, when setting quartz up the other day I instinctively changed it to
en-GB
before my IDE yelled at me telling me it wasn't valid.What do you mean specifically when you โchanged it to
en_GB
โ? I haven't tried yet, but the fact that isn't valid made me think that it might be the lack of support towards one language with multiple regions. Although qwartz theoretically supports it, I can't see any language with more regions added.
The other day (not using this branch) when I set up quartz I set the locale to en-GB
and got a type error as the locale
field is the type ValidLocale
which only accepts locales in the TRANSLATIONS
var in i18n/index.ts
. Since you have added it to there it will be fine from a type hinting prospective.
Hello! ๐
I would like to make changes to the Spanish translation, replacing the infinitive form to conjugated present (of indicative) form, since it is more natural. Furthermore, some past tense verbs have also been replaced by their usage in Spain (not in America).
As for British English, I don't see any difference, but I would recommend adding it. Also, I provided a Catalan translation.
Thanks in advance, L01D