search

jackyzha0 / quartz

🌱 a fast, batteries-included static-site generator that transforms Markdown content into fully functional websites
https://quartz.jzhao.xyz
MIT License
6.82k stars 2.47k forks source link

Fix Non-English Anchor Popover Positioning Issue and Update Type Hint #1252

Closed cmj2002 closed 2 months ago

cmj2002 commented 3 months ago

This PR addresses two issues:

  1. Corrects the non-English anchor popover positioning problem by changing the hash passed to querySelector to decodeURIComponent(hash). This ensures that the popover correctly scroll its content to the corresponding title for non-English anchors. (fix #409)
  2. Updates the type hint of mouseEnterHandler from HTMLLinkElement to HTMLAnchorElement as the passed element is an <a> element, not a <link> element. Reference: MDN Documentation.