search

jackyzha0 / quartz

🌱 a fast, batteries-included static-site generator that transforms Markdown content into fully functional websites
https://quartz.jzhao.xyz
MIT License
7.37k stars 2.54k forks source link

fix(404): update layout based on `grid` refactoring #1580

Closed aarnphm closed 1 week ago

aarnphm commented 2 weeks ago

update a regression given that our 404 pages would display weird layout, given that left and right are empty

cc @saberzero1

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying quartz with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e53f3b
Status: âœ…  Deploy successful!
Preview URL: https://bcd2c66d.quartz-1h4.pages.dev
Branch Preview URL: https://404-layout-regression-grid.quartz-1h4.pages.dev

View logs

jackyzha0 commented 1 week ago

shouldnt left and right already have fixed width anyways? visiting a 404 on quartz today seems to look fine

jackyzha0 commented 1 week ago

i believe this is because 404 doesnt have a normal 'page layout' (as in theres no left/right)

aarnphm commented 1 week ago

Yeah, because 404 doesn't ahve normal layout, wouldn't it just fill in the first grid slot?

aarnphm commented 1 week ago

hmm, I might do something wrong on my end then :)