jackyzha0 / quartz

🌱 a fast, batteries-included static-site generator that transforms Markdown content into fully functional websites
https://quartz.jzhao.xyz
MIT License
7.35k stars 2.54k forks source link

Comments Component now Fails to Load #1582

Closed harrellbm closed 1 week ago

harrellbm commented 1 week ago

Describe the bug I previously had to comments component up and running on my garden. But then updated to the most recent commits and realized that it now fail to load at all. There are not errors in the console and a quick inspection looks like the afterbody div just doesn't exist anymore.

To Reproduce Steps to reproduce the behavior:

updated branch to commit #1575

Load site with comments component

Nothing happens

Checked on desktop using chrome and edge Checked on mobile using chrome and safari all with the same result

Expected behavior Giscus to load

Screenshots and Source

image

You can help speed up fixing the problem by either

My Fork https://github.com/harrellbm/Quartz-Garden Site this can be observed on https://harrellbm.github.io/Quartz-Garden/

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

xlinker1 commented 1 week ago

After updating and trying to use the Comments component for the first time, I ran into the same problem. I've followed all instructions in https://quartz.jzhao.xyz/features/comments . 🥺

commit 1ab9c91df1df799f7a1004200ff890b144d00f19 (HEAD -> v4, upstream/v4)
Author: Aaron Pham <contact@aarnphm.xyz>
Date:   Sun Nov 10 18:13:12 2024 -0500

    feat(mermaid): improvement navigation (#1575)

    * feat(mermaid): custom stuff
saberzero1 commented 1 week ago

Can you check if https://github.com/jackyzha0/quartz/pull/1586 fixes this issue?

harrellbm commented 1 week ago

I can confirm the patch works perfectly! Thanks for the quick response!