Fix full-self-sign-workaround option

jackyzy823 / fxa-selfhosting

Selfhosting your own Firefox Accounts (FxA)!

Mozilla Public License 2.0

94 stars 13 forks source link

Fix full-self-sign-workaround option #24

Closed tlefebvr closed 5 months ago

tlefebvr commented 5 months ago

Fix a sed command executed in fxa-graphql-api container when full-self-sign-workaround option enabled. In the current state, the "Manage account" page won't load.

jackyzy823 commented 5 months ago

Thanks for your PR.

But have you tried to upgrade fxa version to v1.277.3 + (by set version in config.yml) ?

You try to revert back to the state before https://github.com/jackyzy823/fxa-selfhosting/commit/26f06644e487449d66718978e11e4b03db41d2c4

However the old sed line won't fit on new https://github.com/mozilla/fxa/blob/54f14c25d9f526a2b1d45c7dc3a4dcf14e4005a5/packages/fxa-graphql-api/src/backend/auth-client.service.ts

tlefebvr commented 5 months ago

Hi,

No I didn't try as I supposed I will get more trouble with a more recent and untested version. You're right though about the last version of fxa-graphql-api, that's why we should :

keep the current sed command but update to v1.277.3 in config.yml (if functional) ;
revert back the command to fit v1.273.1.

Otherwise the workaround doesn't work.

jackyzy823 commented 5 months ago

As i said in README

Upgrade fxa version everytime when you upgrade this repo.

If you want to use the old fxa version , you should stay on the old commit.