search

jackyzy823 / fxa-selfhosting

Selfhosting your own Firefox Accounts (FxA)!
Mozilla Public License 2.0
99 stars 13 forks source link

Fixed mysql authentication option causing db fail to start #26

Closed RedPine404 closed 6 months ago

RedPine404 commented 6 months ago

The --default-authentication-plugin=mysql_native_password was removed from mysql 8.4 because native-password authentication is deprecated. In mysql 8.4 it's still possible to use the native_password authentication, but the parameter is renamed to --mysql-native-password=ON

jackyzy823 commented 6 months ago

Is this argument working on mysql 8.3 or below ? (If not , could you modify the mysql version in the compose file to like 8.4 ) Thanks

I tested the result is that it starts working from 8.2 And the old argument still exists (could we not delete this line?)

Or just pin on mysql 8.0 (since there's still a long time until EOL). Although it is not a good idea.

Note for myself; Add a warning/note to user for the upgrading of mysql version.

RedPine404 commented 6 months ago

My vote is for pinning version 8.4; this is now the default version that comes with docker tag mysql:8 but would prevent issues being introduced by future releases.

Version 8.4 is the new LTS version that was released on 10 Apr 2024 and will be supported until 30 Apr 2029.

Refer to this GitHub issue as to why the line was removed for mysql 8.4 https://github.com/docker-library/mysql/issues/1048

jackyzy823 commented 6 months ago

It looks like "--default-authentication-plugin" is deprecated but not "--authentication_policy"

jackyzy823 commented 6 months ago

Hi , i've add a commit myself to pin mysql version to 8.4 . Thanks for your contribution!