MRG: Add support for channel types, add .DS_Store to .gitignore, add a conversion to str for fname

mscheltienne commented 2 years ago

Hello, I had to move some of my -raw.fif files to EEGLAB; and I noticed the lack of support for channels types (which is problematic for me). I'm adding it here, using the example channel types provided here.

A quick test shows that everything is working; the now loaded .set file in EEGLAB does show the correct channel types. Please correct me if I'm wrong or if I overlooked anything.

I'm not adding anything to the test (yet) because mne.io.read_raw_eeglab() doesn't seem to support reading the channel types anyway. I will add it there as well when MNE release a version including https://github.com/mne-tools/mne-python/pull/9990

I also added 2 more small improvements:

.DS_Store to the .gitignore for macOS developers.
str(fname) before calling scipy.io.savemat. It's not uncommon for users to provide the path to a file as a pathlib.Path instance and this would raise an error in scipy.

mscheltienne commented 2 years ago

@jackz314 pinging for review.

larsoner commented 2 years ago

Thanks @mscheltienne !

jackz314 / eeglabio

MRG: Add support for channel types, add .DS_Store to .gitignore, add a conversion to str for fname #4