search

jackz314 / eeglabio

I/O support for EEGLAB files in Python.
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

MAINT: Ensure sdist works #6

Closed larsoner closed 2 years ago

larsoner commented 2 years ago

According to https://github.com/conda-forge/staged-recipes/pull/18752 and my local testing, this test should work but fails currently with:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-9_2zenck/setup.py", line 16, in <module>
        with open("requirements.txt") as f:
    FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Once I see CIs come back red (true TDD!), I'll try adding a MANIFEST.in that should fix this.

larsoner commented 2 years ago

@jackz314 please approve the workflows when you get a chance so I can continue!

larsoner commented 2 years ago

@jackz314 one option to make maintenance easier would be to add me as a maintainer or admin of the project, too. I might not be able to review all PRs, but I can try to help when I see things pop up.

If not, then this will require approval for each push. But once I have a PR merged it won't require approval anymore at least!

jackz314 commented 2 years ago

Just added you as a maintainer, thank you!

larsoner commented 2 years ago

I'm not 100% sure if we want pymatreader as a dependency, but it seems worthwhile to add since modern MATLAB writes out HDF5 files that scipy.io.loadmat can't read.

larsoner commented 2 years ago

I realized that pymatreader is only needed at the MNE-Python end to read files so I removed it from requirements.txt. I'll merge this once green and cut a release...

sappelhoff commented 2 years ago

nice, thanks @larsoner and @jackz314 ... this will be good for mne-bids as well.