search

jaclu / tmux-menus

Tmux plugin, Popup menus to help with managing your environment
MIT License
307 stars 11 forks source link

https://ifconfig.me instead of ifconfig.me #26

Closed wilddog64 closed 1 year ago

wilddog64 commented 1 year ago

Appearently that curl ifconfig.me does not return a correct public id address. One has to use https://ifconfig.me to return corrrect one

jaclu commented 1 year ago

Sorry for the late response, I missed the notification :( I use macOS and Linux, and for them either notation works, so I am a bit curious about what environment it fails in. According to the curl man page, it will try until it finds a working protocol, so shouldn't normally fail for you, however, one advantage of giving the https: // prefix is that it will reduce the resources spent figuring out the protocol. Either way, I added your change, thx for the update!

wilddog64 commented 1 year ago

I am a Mac user. I am not sure why it returns a different IP address in different ways. Under zsh shell I use this to find my public ip address:

dig +short myip.opendns.com @resolver1.opendns.com

This is how I find out yours are different.

Anyway, thank you for a quick response and fix the problem.

Wildddog64

On Thu, Jan 19, 2023 at 1:26 AM Jacob Lundqvist @.***> wrote:

Sorry for the late response, I missed the notification :( I use macOS and Linux, and for them either notation works, so I am a bit curious about what environment it fails in. According to the curl man page, it will try until it finds a working protocol, so shouldn't normally fail for you, however, one advantage of giving the https: // prefix is that it will reduce the resources spent figuring out the protocol. Either way, I added your change, thx for the update!

— Reply to this email directly, view it on GitHub https://github.com/jaclu/tmux-menus/issues/26#issuecomment-1396673891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFWGVGOJCHTBWJ2ZKNECOLWTECDTANCNFSM6AAAAAAT3OMY24 . You are receiving this because you authored the thread.Message ID: @.***>