search

jacmoe / conan-assimp

Conan.io package for Assimp
BSD 3-Clause "New" or "Revised" License
6 stars 11 forks source link

Stable/3.3.1 #7

Closed pvicente closed 6 years ago

pvicente commented 6 years ago

Hi @jacmoe,

This PR includes some fixes for your library which is already in conan-center.

Please create stable/3.3.1 branch in your repo based on these changes. I'm going to submit another version 4.1.0 of this library so you can keep both version in different branches.

CI jobs will only submit artifacts to bintray from stable branches.

shearer12345 commented 6 years ago

@pvicente these look great. Thanks for putting the time into them.

@jacmoe do you have a chance to merge these soon? That would be totally awesome

pvicente commented 6 years ago

@shearer12345 there is also https://github.com/jacmoe/conan-assimp/pull/8 for version 4.1.0 it would be great if @jacmoe merges it too.

jacmoe commented 6 years ago

Yes I agree ;-) Been busy with the family, but I am going to be on it this week :-D

shearer12345 commented 6 years ago

Awesome. That's great news :)

-- John Shearer

On 27 March 2018 at 13:11, Jacob Moen notifications@github.com wrote:

Yes I agree ;-) Been busy with the family, but I am going to be on it this week :-D

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jacmoe/conan-assimp/pull/7#issuecomment-376501821, or mute the thread https://github.com/notifications/unsubscribe-auth/ADquLdyOk27vgGzk8UxNIxI9i3dh73mtks5tiixVgaJpZM4Sm_IF .

danimtb commented 6 years ago

any update on this @jacmoe?

The Conan team would like to have this changes available in the official conan package.

Thanks!

jacmoe commented 6 years ago

Uhm, whoops - yes :smile: After two times the flu and a new computer I am getting ready to do this! Thank you for your patience. I am very close to having set my new machine up the way I want it, so ...

jacmoe commented 6 years ago

I merged this directly into stable/3.3.1 :) Github is apparently not intelligent enough to recognize it, or I am not intelligent enough to do it properly?

danimtb commented 6 years ago

Yeah, maybe it didn't catch the way you did the merge. But dont worry, I see the commits there.

Thank you so much @jacmoe!