search

jacob-ebey / styled-components-ts

Visual primitives for the component age. Use the best bits of ES6 and CSS to style your apps without stress and the added benefits of TypeScript 💅
Do What The F*ck You Want To Public License
150 stars 5 forks source link

Update styled-components peerDependency range #17

Closed mrmartineau closed 5 years ago

mrmartineau commented 5 years ago

This change should stop the warnings that occur when installing this package, when using styled-components v4 or above. This addresses issue #15

jacob-ebey commented 5 years ago

Thanks for the contribution.

elie222 commented 5 years ago

v4 doesn't export StyledComponentClass. How do you have this working?

danielkcz commented 5 years ago

Looks like that StyledComponentClass was just renamed to StyledComponent in https://github.com/DefinitelyTyped/DefinitelyTyped/commit/5c49d4ddc6f5bd06c5cf04d911398f3db05ead54

Edit: Why is it actually needed to re-export that type? It's not used in the actual code.

mrmartineau commented 5 years ago

This PR should probably be reverted since styled-components 4+ can do this natively. @jacob-ebey what do you think?

jacob-ebey commented 5 years ago

@mrmartineau, it's already published to NPM and I don't want to have to deal with that cluster of a versioning system.

mrmartineau commented 5 years ago

@jacob-ebey I could submit a new PR with the relevant changes?