search

jacob-macleod / Dolphin-Flashcard-App

http://www.dolphinflashcards.com
MIT License
1 stars 3 forks source link

MINOR: Development #137

Open kenudeh opened 1 week ago

kenudeh commented 1 week ago

I've removed the /calculate-card-stats endpoint from statistics.md and rearranged the endpoints in goal.md to reflect the new order of things in goal.py. Meanwhile, it appears that /get-weekly-xp and get-total-xp were never part of the docs at any point.

jacob-macleod commented 1 week ago

Hi there, thanks for the pull request. Is this to resolve https://github.com/jacob-macleod/Dolphin-Flashcard-App/issues/125? If so, are the docs in mintlify format?

Also, I've added MINOR: to the start of the MR, which tells the pipeline what type of change it is, so it can check the version has been updated correctly

kenudeh commented 1 week ago

No, it's not for Mintlify, that'll be ready soon. This PR is for the API method that was taken out from the docs.

jacob-macleod commented 6 days ago

Ah great thanks. Please could you update the version number in __init__.py? This is probably a MINOR change, which is defined by the MINOR: at the start of the MR title, so the new version should be 3.5.0

Please could you also document the changes and the new version in CHANGELOG.md, following the existing style there? Thanks

Once you've done that, the pipelines should pass, and I'll merge

kenudeh commented 5 days ago

Alright, I'll do those today.