jacob-macleod / Dolphin-Flashcard-App

http://www.dolphinflashcards.com
MIT License
1 stars 3 forks source link

Fix pipeline error and improve code base accessibility #73

Closed jacob-macleod closed 4 months ago

jacob-macleod commented 4 months ago

There are several main tasks for this DevSecOps focused issue:

This must be done before contributors can really work on code. Right now, the backend server must be running locally, connected to the live production database, to do any contributing

jacob-macleod commented 4 months ago

A different key is used on the backend.The firebase_confdig.json file is still used, as well as another file with a genuinely secret API key. Thus, according to https://firebase.google.com/docs/projects/api-keys, I can show it, so long as I'm not using:

According to https://infosecwriteups.com/is-it-safe-to-expose-your-firebase-api-key-bf2a318c0f29, people using the API key can make lots of sign in requests, but they can do that anyway using the app. The idea that it is safe is echoed by https://stackoverflow.com/questions/37482366/is-it-safe-to-expose-firebase-apikey-to-the-public, as does https://medium.com/@paulbreslin/is-it-safe-to-expose-your-firebase-api-key-to-the-public-7e5bd01e637b

jacob-macleod commented 4 months ago

The coding side of this is now done - next, the size of the docker image needs to be reduced

jacob-macleod commented 4 months ago

It looks like the installed node modules is the reason for the large docker image. I've made the pipeline remove this automatically. A MR will now be made to test the new pipeline