search

jacob404 / promod-future

GNU General Public License v3.0
7 stars 1 forks source link

Tank takes self-damage from hittables #82

Closed MattNF closed 9 years ago

jbzdarkid commented 9 years ago

Since you haven't done anything with it for a few months

jbzdarkid commented 9 years ago

Now that I look, this seems to just be in l4d2_hittable_control.sp, the convar is hc_disable_self_damage. It was disabled.

jbzdarkid commented 9 years ago

Testing reveals that this setting does nothing.

Attano commented 9 years ago

I have it set to 1 on my servers and tank doesn't get any damage from hittables. https://github.com/Attano/L4D2-Competitive-Framework/blob/master/addons/sourcemod/scripting/l4d2_hittable_control.sp#L108

jbzdarkid commented 9 years ago

Testing reveals that I don't know how to test.

HighCookie commented 9 years ago

so its fixed? well done everyone

jbzdarkid commented 9 years ago

I wanted to make sure I knew how to test before closing; should be certain of self tonight.

jbzdarkid commented 9 years ago

Good to go.

jacob404 commented 9 years ago

is this merged into current build?

jacob404 commented 9 years ago

make whatever changes are necessary in currentbuild/update before closing issues so they dont get forgotten

jacob404 commented 9 years ago

also its been set to 1 in pro mod since the plugin was added, but tanks are still taking damage. can i get some insight into how you fixed this?

jbzdarkid commented 9 years ago

Huh well the change I made was to set the variable to 1 which seemed to fix it, but if that's not a new concern, I'll look back into the issue.

jbzdarkid commented 9 years ago

https://github.com/jacob404/promod-future/blob/master/addons/sourcemod/scripting/l4d2_hittable_control.sp#L70

jbzdarkid commented 9 years ago

cb8fc29fbe88fcba743a18395c2b64558449e3f3

jacob404 commented 9 years ago

but that cvar has been set to 1 in pro mod since the plugin was made, i dont see how that could fix it

jacob404 commented 9 years ago

https://github.com/jacob404/promod-future/blob/master/currentbuild/Update/cfg/cfgogl/promod/promod.cfg#L112

Attano commented 9 years ago

You probably forgot to update the plugin itself inside the zip package, might be an outdated or wrong version. I suggest using whatever is in my comp framework repo. 99% of it is tested and works(unless it's something I don't use like witch/tankifier/paneltext etc). If you see my nickname in the authors list, the reliability increases from 99% to 100%. I would never upload something I have personally modified without very proper testing.