search

jacobcuison / pe

0 stars 0 forks source link

Unspecific error messages regarding dates #6

Open jacobcuison opened 9 months ago

jacobcuison commented 9 months ago

Problem

Inputting an invalid date gives an error message that suggests an invalid date format was used (DateTime should be in the format of 'dd-MM-yyyy HHmm').

I believe that the error message should be more specific by identifying the fact that the date (e.g. 30th February) is not a valid date. This makes MedBook more intuitive for users to identify and correct their mistake, rather than trying to find flaws in their DateTime format.

Steps to Reproduce

  1. Type in the following command: addrecord 1 d/30-02-2023 1800 c/Fever m/Paracetamol.

image.png

soc-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect error message

Screenshot 2023-11-17 at 4.26.00 PM.png

Hi, when i run the command addrecord 8 d/13-01-1997 2400 c/test-00 m/testmed, it seems that the message is still pertaining to the format of the date time that i have inputted, rather than 2400 being an invalid time input. However, this is unlikely to cause any major issues, might just be a bit confusing when the client accidentally mistypes.

[original: nus-cs2103-AY2324S1/pe-interim#116] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]