search

jacobdufault / cquery

C/C++ language server supporting multi-million line code base, powered by libclang. Emacs, Vim, VSCode, and others with language server protocol support. Cross references, completion, diagnostics, semantic highlighting and more
MIT License
2.34k stars 163 forks source link

Warn user to disable Microsoft C/C++ extension if they have it enabled #37

Open jacobdufault opened 6 years ago

jacobdufault commented 6 years ago

Warn user to disable Microsoft C/C++ extension if they have it enabled via a notification in vscode or similar.

When both are enabled there are confusing errors, ie, goto definition gets very slow. Native code debug and clang format are available in separate extensions outside of the Microsoft C/C++ one.

balta2ar commented 6 years ago

What is good to bring along with this change is a clear description of how this project is different to MS C/C++ extension so that a user knows each extension's strong and weak points and could have a better idea which of two could be a better match to her needs. Could you please add something along the lines to the README? I'm not sure my request could be labeled good first issue because I think the author should know better about the differences.

MaskRay commented 6 years ago

Should be documented in https://github.com/jacobdufault/cquery/wiki/Visual-Studio-Code

jacobdufault commented 6 years ago

This is not an obvious issue to the user, and I do not expect users will read docs.

MaskRay commented 6 years ago

It would be very rude to pop up something telling the user "you should disable the official plugin, otherwise xxx"

jacobdufault commented 6 years ago

I think a broken experience is worse than being rude, though I agree being rude is not good. The statement can be worded to not sound offensive, but ultimately I'd like to submit a PR to the C++ extension which allows indexing to be disabled, and then tell the user they should disable C++ indexing.

hensz commented 6 years ago

I'm totally pro such a "warning" if this causes problems. But most important, the documentation should explain how to replace the Microsoft extension with something equivalent, e.g. what do I need to install to debug just as with cpptools?

jacobdufault commented 6 years ago

You can use https://github.com/WebFreak001/code-debug. I'm not sure how well it works in comparison to cpptools.

hensz commented 6 years ago

I just did a quick test, and no, this extension is no real alternative to cpptools. Also code formatting doesn't work anymore when disabling cpptools :-(

jacobdufault commented 6 years ago

We should probably send a PR to cpptools then to add a setting to disable indexing.