jacobfc / VAMP

Voigt Automatic MCMC Profiles
0 stars 2 forks source link

Make different fitting settings "parameterized" #9

Open jacobfc opened 5 years ago

jacobfc commented 5 years ago

Currently, settings for the VAMP fits (chi-squared thresholds, number of attempts at convergence, etc.) are hard-coded into VPfits.py .

It would be useful to pass VAMP a configuration file, that would specify these various parameters. This would allow users to run VAMP with various settings more easily (e.g. a "quick" VAMP setting with less stringent convergence criteria, or a "thorough" setting with more attempts at convergence before giving up, etc.)

I believe this should be done so that there are default values in VAMP, but individual values can be over-ridden using a config file (rather than forcing users to specify a bunch of parameters which they may not understand fully).

Things that I can think of which would be useful to specify: