Closed CallumWSimprints closed 3 months ago
Thanks so much! For the PR, and for the kind words.
I think test_delong.py would be great!
Thank you for the lightning-fast reply!
Test added in a new file called test_delong.py
, ready for your review @jacobgil.
Hi,
First of all, amazing library - great work! ✨
I've spotted a potential bug surrounding negation in
numpy
. The ('-') syntax does not work for reversing a boolean array, which seems to get passed to thecompute_ground_truth_statistics
in certain scenarios (e.g., sometimes, but not always, when asking for the fast delong solver).I've updated the code to use the tilde sign ('~'). I hope this small change helps as it works for both integer and boolean arrays.
Error
Minimal reproducible example & test case:
I can add this test to the library if you can let me know where it should go 😄 e.g., a new file called
test_utils.py
, or similar?Keep up the good work, Callum