search

jacobhood / Challonge-DotNet

MIT License
2 stars 4 forks source link

missing 'ranked' value throwing exceptions #20

Closed david-shattuck closed 3 months ago

david-shattuck commented 3 months ago

My "create a tournament" code suddenly started failing (I think it has been a 100% failure rate) a few days ago. At first glance it seems like the problem is challonge-dotnet is expecting the response from challonge to contain a value for 'Ranked' but it doesn't.

I don't know what 'Ranked' is or what it's used for, so I'm afraid to just say "oh just make it nullable" - but Ranked isn't listed in the challonge api sample response (https://api.challonge.com/v1/documents/tournaments/create). Maybe they quietly removed it? If so, did they quietly remove other stuff?

This same problem is causing my "get all pending tournaments" code to fail as well.

Screenshot 2024-07-11 123923

jacobhood commented 3 months ago

Hey David, thanks for your ongoing engagement with this project. I'm out of town at the moment but when I return early next week I'll review, presumably merge, publish the new package to Nuget, etc.

david-shattuck commented 3 months ago

Hi Jacob - Any news on this? Very sorry to pester but I'm doing a lot of manual updating while this persists (which also means delays for my users), so I'm eager to get it sorted. Happy to help if there's anything else I can do, just let me know.

jacobhood commented 3 months ago

Hey David, apologies once again for delays, I just merged your changes (thanks for taking care of that) and uploaded version 3.0.2 to NuGet, it should be available shortly.