search

jacobkaufmann / evangelion

a prototype ethereum block builder
Apache License 2.0
84 stars 10 forks source link

Proposer payment tx will fail when made to contracts like Lido's #53

Open bertmiller opened 1 year ago

bertmiller commented 1 year ago

Flagging to you all that the hardcoded 21,000 gas payment txs will run out of gas if you submit to an address that is a contract, e.g. Lido's fee recipient. See the hard coded variable here: https://github.com/jacobkaufmann/evangelion/blob/master/src/builder.rs#L640

An example that uses more than 21k gas:

https://etherscan.io/tx/0x262c315bd08396082d7e93d9e2c8e3dfb96d5d8611267042392a00979a8ea740

The simple fix is to up the gas limit by a bit. I believe we used 24,000 for awhile with success. Not sure how we estimate it these days.

jacobkaufmann commented 1 year ago

good look, thank you! we will move toward some more general proposer payment abstraction soon, and yea we definitely need to make accurate gas allowance part of that.