search

jacobkimmel / pytorch_convgru

Convolutional Gated Recurrent Units implemented in PyTorch
MIT License
191 stars 41 forks source link

Can't help say something about this repo #11

Closed JasonLeeFdu closed 3 years ago

JasonLeeFdu commented 3 years ago
  1. terrible variable naming
  2. hidden states are not passed in the GRU chain
  3. nn.Module list question that is already mentioned in other "issues"

1.变量名取得比较不准确混乱

  1. 隐状态其实并没有在GRU链条中传递，使用方式也有问题
  2. 其他issue也提到 nn.ModuleList问题