jacobmoncur / QuiltViewLibrary

Android Quilt View Library
554 stars 191 forks source link

setRowCount(int) and setColumnCount(int) shouldn't receive -1 as undefined value #28

Open Rafhack opened 8 years ago

Rafhack commented 8 years ago

setupVertical() and setupHorizontal() methods on QuiltViewBase class, call setColumnCount(int) and setRowCount(int) passing -1 as undefined value, this makes GridLayout throw an IllegalArgumentException. Instead, these methods should pass UNDEFINED constant as undefined value.

bag7dad commented 8 years ago

solve it by remove //this.setColumnCount(-1); and //this.setColumnCount(-1); in vertical too

arefbhrn commented 7 years ago

@medozeus you mean setRowCount in horizontal i think it's better to set it undefined: this.setRowCount(UNDEFINED); // in horizontal this.setColumnCount(UNDEFINED); // in vertical