jacobnzw / SSMToybox

Nonlinear Sigma-Point Kalman Filters based on Bayesian Quadrature
MIT License
12 stars 0 forks source link

BQTransform: Cleaner Passing of Kerneland Point-Set-related Parameters #27

Closed jacobnzw closed 3 years ago

jacobnzw commented 3 years ago

Having this signature of __init__()

class BQTransform(MomentTransform, metaclass=ABCMeta):
    def __init__(self, dim_in, dim_out, kern_par, model, kern_str, point_str, point_par, estimate_par, **kwargs):

where the kern_par, kern_str and point_str, point_par are separate is messy as hell! Not to mention their nonsensical order.

These should be joined together into a dicts! So kernel_spec : dict would contain info from kern_str and kern_par, and similarly for point_spec : dict. In the end, it could look like this:

def __init__(self, dim_in, dim_out, model, kernel_spec, point_spec, estimate_par, **kwargs):