jacobobryant / biff

A Clojure web framework for solo developers.
https://biffweb.com
MIT License
877 stars 41 forks source link

Signin via new email yields Sign-up-like email but doesn't create session #167

Closed Invertisment closed 1 year ago

Invertisment commented 1 year ago

I found that if I try to sign-in via unregistered email I still get an account but I don't get a session when I enter the code. I think this is a bug.

How to reproduce:

So I didn't get a session to sign in with and it created the user.

The email link has SignUp and SignIn header and texts:

TO: new@aaaa.com
SUBJECT: Sign up for My Application

We received a request to sign in to My Application using this email address. Enter the following code to sign in:

981163

This code will expire in three minutes. If you did not request this code, you can ignore this email.

So the subject is "sign UP" and the content is "sign IN".

So one of these have to be changed to either redirect into /app or the UI has to crash and say that this user doesn't exist :thinking_face: