jacobobryant / biff

A Clojure web framework for solo developers.
https://biffweb.com
MIT License
829 stars 40 forks source link

Clean up trenchman install artifacts #172

Closed mathisto closed 10 months ago

mathisto commented 10 months ago

Clean up

Just a small change to consider for the server-setup.sh script.

The trenchman install step deletes the tarball but leaves a few artifacts:

  1. README.md
  2. LICENSE
  3. CHANGELOG.md

This PR aims to take the boyscout approach of "Leave no trace".

  1. We make a temp folder.
  2. Extract the tarball to the folder vice the app root.
  3. Copy the file from the temp folder.
  4. Delete the tarball and temp folder.
  5. Profit???
jacobobryant commented 10 months ago

Thanks for catching this! And love the gif 🙂

mathisto commented 10 months ago

Thanks for catching this! And love the gif 🙂

Every time I come across it, I watch it at least a couple times; it always makes me giggle.