jacobobryant / biff

A Clojure web framework for solo developers.
https://biffweb.com
MIT License
829 stars 40 forks source link

Disable ssh-agent if it is disabled in user's SSH configuration #175

Closed olavfosse closed 9 months ago

jacobobryant commented 9 months ago

Can you give me some details on the motivation for this change? Do you have these options set in your own config? I read the SSH_CONFIG docs you pasted, but I'm not quite sure if the idea is that the user setting these options means they don't want to use ssh-agent or if when these options are set, the ssh-agent won't work anyway so we might as well not try. If it's the former, I'm not sure that actually matters? We're not starting a long-running ssh-agent; once the bb task finishes, the agent gets killed. There is already the :biff.tasks/skip-ssh-agent option if someone really doesn't want the agent to be used at all for some reason (mainly I put it there in case there were bugs, so there'd be a workaround instead of having bb tasks totally broken).

olavfosse commented 9 months ago

On further thought I've decided this is not a good change to make so i'm closing this pr.

tl;dr: