search

jacobobryant / biff

A Clojure web framework for solo developers.
https://biffweb.com
MIT License
829 stars 40 forks source link

fix: remove default-jre #201

Closed credmp closed 2 months ago

credmp commented 2 months ago

The Docker base image (temurin-17) already has Java-17, the default-jre would also install Java 11. This reduces the image size from 1.2GB to 800MB.

credmp commented 2 months ago

I retract this request, there is a situation that the temurin is not sufficient.

jacobobryant commented 2 months ago

I'm curious about what the situation is where default-jre is needed after all? It's been a while since I wrote the Dockerfile; if default-jre is installing Java 11 that sounds like something we'd want to avoid.