search

jacobobryant / biff

A Clojure web framework for solo developers.
https://biffweb.com
MIT License
877 stars 41 forks source link

Added --protocol=29 for rsync backwards compatibility #232

Closed biutthapa closed 1 week ago

biutthapa commented 1 month ago

Adds push-files compatibility to Intel Macs.

jacobobryant commented 1 month ago

:+1: planning to test and merge this soon

jacobobryant commented 1 month ago

In reading the docs for --protocol in man rsync, it looks like this flag is mainly intended for use with the --write-batch option. I would've thought that in regular circumstances, rsync would negotiate the protocol version with the server automatically, but maybe that isn't the case. So just to double check: if you run something like rsync README.md app@<your server domain>:README.md, with and without the --protocol=29 option, it only works when the --protocol option is set, right?

Also out of curiosity can you paste the output of rsync --version | head -1 both on your local machine and on the server (ec2 right?). I'm wondering if the client or the server has the older version.

biutthapa commented 1 week ago

It's when the sender(client) is an older version. On the server: rsync version 3.2.7 protocol version 31 On the local machine: rsync version 2.6.9 protocol version 29

jacobobryant commented 1 week ago

👍 thanks for checking.

jacobobryant commented 1 week ago

Just released this. You can upgrade your app's :dev alias dependencies to:

:extra-deps {com.biffweb/tasks {:git/url "https://github.com/jacobobryant/biff",
                                :git/tag "v1.8.26"
                                :git/sha "1a1eccf"}}