search

jacobobryant / platypub

A publishing platform built with Biff
MIT License
65 stars 13 forks source link

Mobile hamburger and dropdown menu #1

Closed jeffp42ker closed 2 years ago

jeffp42ker commented 2 years ago

This dropdown helps me navigate the app on my phone, if it fits with your plans.

jacobobryant commented 2 years ago

Sounds good to me! However currently when I click the hamburger icon, it disappears, so there's no way to dismiss the menu on mobile. It's because the sidebar (and thus the new menu component) uses position: fixed (https://github.com/jacobobryant/platypub/pull/1/files#diff-7232e7012acad83756173b01a3b2c82ed746df53747ff6443541e287ee5a006bR50), so it overlays the hamburger icon. I don't remember exactly why I used position: fixed (maybe it was just path of least resistance), but that might be worth changing. See also the ml-64 here: https://github.com/jacobobryant/platypub/pull/1/files#diff-7232e7012acad83756173b01a3b2c82ed746df53747ff6443541e287ee5a006bR102

hamburger

jeffp42ker commented 2 years ago

The menu is dismissible now.

hamburger-animation