search

jacobobryant / platypub

A publishing platform built with Biff
MIT License
65 stars 13 forks source link

Add a :post/sites attribute to the :post schema #46

Closed jeffp42ker closed 2 years ago

jeffp42ker commented 2 years ago

Follows the recommended minimal implementation: use a native html single-select element

Resolves #39

jacobobryant commented 2 years ago

Looks great; Github says there are merge conflicts though.

jeffp42ker commented 2 years ago

Yeah, passing the db felt awkward; thanks for the tip!

Are you seeing merge conflicts? I'm seeing "This branch has no conflicts with the base branch"

jacobobryant commented 2 years ago

Huh that's strange--github shows me this: image Must be a glitch, I see your PR is already based on the latest master commit anyway. I'll just figure out how to merge it from the CLI :).

jeffp42ker commented 2 years ago

I used the same fork as my previous PR, doing a git pull to be sure I didn't miss something.

This resulted in the merge commit and fork's previous commits looking like new commits in the subsequent PR. That may have caused this situation.

jacobobryant commented 2 years ago

Oh interesting, good to know!