search

jacobparis-insiders / sly

Monorepo for Sly CLI
https://sly-cli.fly.dev/
153 stars 11 forks source link

esbuild should be a CLI dependency #17

Closed wKovacs64 closed 8 months ago

wKovacs64 commented 8 months ago

esbuild is required for ts-loader.js to compile TypeScript transformers, so it should be in dependencies (not devDependencies where it is now), right? It just so happens to work fine in Remix projects (the most likely place Sly is used today, I assume) because esbuild is already there, but when I was testing in an empty project, it threw an error because esbuild was not found.

jacobparis commented 8 months ago

Nice catch! This has been fixed and is available in one of the many new versions I created while trying to get CI to npm to work

IHIutch commented 7 months ago

Hm, I still appear to be having this issue using 1.7.0 and pnpm

jacobparis commented 7 months ago

Hm, I still appear to be having this issue using 1.7.0 and pnpm

Sorry about this, somehow that commit didn't make it into the last release. Released in 1.8.0