search

jacobrs / TeamStudy

E-Learning application repository for SOEN 341 team 5 tutorial A.
8 stars 5 forks source link

#111 Study group assignement #112

Closed ONourry closed 7 years ago

ONourry commented 7 years ago

When a study group is created, the new group is now assigned to the user who created it.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 77.778% when pulling 6b8989d506c7a631c548007acf3abcd75a102287 on studyGroup_assignement into 3f6c365e451174f348d84447030b63d5a352d6cc on master.

simon-bourque commented 7 years ago

Front end looks good to me

jacobrs commented 7 years ago

@simon-bourque let me test this.

ONourry commented 7 years ago

The devtool is returning an undefined in the console. It doesnt bother the creation process though. I'll still remove it since it we obviously dont want it.

ONourry commented 7 years ago

user_creation

ONourry commented 7 years ago

The type error V has been there for quite a while now. It's probably on the main too. I dont get any other error when creating a user

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 77.778% when pulling 258f8e2b0671511ee6b0cc767668494458c642f5 on studyGroup_assignement into 3f6c365e451174f348d84447030b63d5a352d6cc on master.

simon-bourque commented 7 years ago

@jacobrs Have you tested this yet? Is it working good?

ONourry commented 7 years ago

user_creation2

ONourry commented 7 years ago

You're right there seems to be another error triggered. This one does not prevent the user creation either though. I will try to find what is triggering it but overall it doesn't seem to have any impact on any functionality.

ONourry commented 7 years ago

After investigating this error. The issue seems to be with these lines in the UserReducer file: case ADD_USER : return { data: [action.user, ...state.data], };

The state.data property returns undefined initially. If a user is created and then the website is refreshed, the error never appears again. If no refresh is done, the error will keep showing up for every user created. The user creation however, is done normally every time regardless if the error shows up in console or not. This lets me think that the state.data is not really undefined since the correct user information is sent to the server.

My changes did not touch this file at all so that seems very weird to me. The fact that a refresh fixes the issue also seems like an weird behavior to me. If anyone has an idea of what might be the issue I am open to any idea/suggestion. I'll keep looking into it in the meanwhile.

ONourry commented 7 years ago

Ok, i just looked really quickly and this behavior happens on the main branch as well. My changes have nothing to do with it.

simon-bourque commented 7 years ago

@ONourry Ok but I'd still wait for jacobs approval as well because he said he wanted to test it