search

jacobrs / stocklion

Custom built chess bot in c++. Coding night personal project to compete against similar bots abiding by the UCI protocol.
MIT License
4 stars 0 forks source link

Fixed codacy issues #25

Closed jacobrs closed 6 years ago

jacobrs commented 6 years ago

Improved code quality by following Codacy recommendations.

codecov-io commented 6 years ago

Codecov Report

Merging #25 into master will decrease coverage by 3.37%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   98.16%   94.78%   -3.38%     
==========================================
  Files          32       32              
  Lines        1252     1343      +91     
==========================================
+ Hits         1229     1273      +44     
- Misses         23       70      +47
Impacted Files Coverage Δ
datastructures/pieces/Piece.cpp 100% <ø> (ø) :arrow_up:
converters/FENConverter.cpp 100% <100%> (ø) :arrow_up:
util/UnicodeTable.cpp 100% <100%> (ø) :arrow_up:
datastructures/pieces/Piece.h 100% <100%> (ø) :arrow_up:
converters/PGNConverter.cpp 62.08% <0%> (-21.01%) :arrow_down:
datastructures/Board.cpp 99.34% <0%> (-0.66%) :arrow_down:
tests/datastructures/BoardTests.cpp 100% <0%> (ø) :arrow_up:
tests/converters/PGNConverterTests.cpp 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73abab...8c01b00. Read the comment docs.

benrs commented 6 years ago

How did we lose code coverage?

jacobrs commented 6 years ago

I was wrong, I just hadn't merged master into the branch.