Support for Sonoma + user space TCC + reset fix + modernised string interpolation + errors to stderr

jacobsalmela / tccutil

♿️ Command line tool to modify OS X's accessibility database (TCC.db)

https://jacobsalmela.com/2014/07/14/tccutil-py-command-line-utility-modifying-accessibility-database-os-x/

GNU General Public License v2.0

471 stars 62 forks source link

Support for Sonoma + user space TCC + reset fix + modernised string interpolation + errors to stderr #65

Closed tnarik closed 10 months ago

tnarik commented 11 months ago

Added support for Sonoma
Added support for -uor --user so that user specific TCC database can be modified.
-u without parameters will attempt modifications of the current user.
Username is checked and, if not existing in the system, raised as an error with a hint.
Renamed service to default_service for clarity (as global service is set from arguments).
Normalised all help strings to NOT end in ".", matching the default -h string format.
Moved from str.format() and modulo operator (%) to f-strings.
Error output now goes to stderr.
Fixed behaviour for ACTION = reset, by ALLOWING unknown arguments to be passthrough.
Fixed behaviour for ACTION = reset, by using the absolute path to/usr/bin/tccutil, so that there is no clash if using wrapper scripts (such as Homebrew does).
Updated README.md information

jacobsalmela commented 11 months ago

Thank you for giving the utility some love. It has been neglected.

Also for bumping the version.

It all looks reasonable. The repo lacks in tests so let me look it over some more and I'll get back to you.

You have two PRs but this looks to have both. Is there a special intent for both?

tnarik commented 11 months ago

Both pull request contain the same code. #64 comes from the branch I used in my fork, and this one from the final merged code. I don't usually contribute much to projects and wasn't sure what was the preference here, so that's why I didn't cancel any of them.

Thanks for the tool, @jacobsalmela , I used it in the past with a mix of ad-hoc sqlite3 code when something was not supported, but thought it was a good idea to propose the changes I need and bring it up to date (I'm installing Sonoma macs now :D ).

One note: one of the print changes (the unrecognised command) would make the Homebrew Formula test fail because I added double quotes to align messages a bit. Something to keep in mind.

tnarik commented 10 months ago

Thanks so much, @jacobsalmela . I created a pull request on homebrew-core to get it officially supported there.

jacobsalmela commented 10 months ago

https://github.com/Homebrew/homebrew-core/pull/156907