Closed sfaiss closed 1 year ago
Can you add a blurb/example to the documentation about how you setup with use_secure since you said you had it working on your setup?
Thanks for adding this.
Sure, no problem. I just added a new section at the bottom of the main page.
Merged! Thanks for the help and documentation :)
This PR adds fine-grained control over the SSL/TLS-settings. It includes the following changes:
_tcp_socket_check()
handles those exceptions now as well.wrap_socket()
function is deprecated. Instead, a context with secure default settings is created.use_secure
(instead of the default context whenuse_secure=True
).Alternative to 3.: Instead of the option to pass a SSL context directly to
use_secure
, a new optional keyword-argument could be used as well.This implementation is working on my side, but I still left "untested" in the docstring until someone else can confirm.