search

jacobseiler / rsage

The Reionization using Semi-Analytic Galaxy Evolution model.
MIT License
1 stars 0 forks source link

GridReionMod -1 Issue #1

Closed jacobseiler closed 6 years ago

jacobseiler commented 6 years ago

The new variable GridReionMod tracks the history of a galaxies value of ReionizationModifier. The value is updated whenever do_reionization() is called which is in infall_recipe() and strip_from_satellite().

However, strip_from_satellite() is only called if there is Hot Gas to be stripped from the satellite galaxy. If HotGas <= 0.0, then strip_from_satellite() is never called and the reionization modifier for the galaxy is never updated. Hence we can have galaxies that exist at a specified redshift, but who's value for GridReionMod is -1 (i.e., the initialized value).

While GridReionMod could be updated outside of these two function calls, it may be useful to only calculate the value of ReionizationModifier for galaxies who actually USE the reionization modifier. Will need to think on this more.

jacobseiler commented 6 years ago

I don't think this is an issue at all actually. In my plotting scripts all I've done is ensured that I'm only calculating statistics using galaxies that don't have a negative value for GridReionMod; i.e.,

reionmod = G.GridReionMod[w_gal, current_snap]
mass_reionmod_central = mass_central[reionmod > -1]
reionmod = reionmod[reionmod > -1]

This would also allow me to look at stats regarding the number of halos that don't get their ReionMod updated.